[ovs-dev] [PATCH ovn] Add OVN schema version checks in Makefile.am

Han Zhou zhouhan at gmail.com
Thu Aug 8 17:18:39 UTC 2019


On Thu, Aug 8, 2019 at 5:58 AM <nusiddiq at redhat.com> wrote:
>
> From: Numan Siddique <nusiddiq at redhat.com>
>
> This was left out during the OVS/OVN split.
>
> We still need to handle the below in the automake files
>  - OVN northbound/southbound E-R diagram
>  - OVN northbound/southbound schema documentation
>  - ovn-architecture manpage generation.

Shall we add these to split-TODOs so that we don't forget?

>
> The above requires some amount of work (mainly in pointing to the correct
> path for ovsdb-doc/ovsdb-dot.in) and will be added in a separate patch.
>
> OVN schema version checks is very important and hence only that is
considered
> in this patch.
>
> Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
> ---
>  Makefile.am | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index 16d4d02e4..f886a8e63 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -490,6 +490,20 @@ dist-docs:
>         VERSION=$(VERSION) MAKE='$(MAKE)' $(srcdir)/build-aux/dist-docs
$(srcdir) $(docs)
>  .PHONY: dist-docs
>
> +
> +# Version checking for ovn-nb.ovsschema.
> +ALL_LOCAL += ovn-nb.ovsschema.stamp
> +ovn-nb.ovsschema.stamp: ovn-nb.ovsschema
> +       $(srcdir)/build-aux/cksum-schema-check $? $@
> +CLEANFILES += ovn-nb.ovsschema.stamp
> +
> +# Version checking for ovn-sb.ovsschema.
> +ALL_LOCAL += ovn-sb.ovsschema.stamp
> +ovn-sb.ovsschema.stamp: ovn-sb.ovsschema
> +       $(srcdir)/build-aux/cksum-schema-check $? $@
> +
> +CLEANFILES += ovn-sb.ovsschema.stamp
> +
>  include Documentation/automake.mk
>  include m4/automake.mk
>  include lib/automake.mk
> --
> 2.21.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Acked-by: Han Zhou <hzhou8 at ebay.com>


More information about the dev mailing list