[ovs-dev] [PATCH] ovn-northd: Fix ARP respond flows flapping.

Justin Pettit jpettit at ovn.org
Fri Aug 9 18:11:15 UTC 2019


> On Aug 1, 2019, at 11:08 AM, Han Zhou <zhouhan at gmail.com> wrote:
> 
> > diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
> > index eb6c47c..212aa88 100644
> > --- a/ovn/northd/ovn-northd.c
> > +++ b/ovn/northd/ovn-northd.c
> > @@ -3495,7 +3495,7 @@ lsp_is_enabled(const struct nbrec_logical_switch_port *lsp)
> >  static bool
> >  lsp_is_up(const struct nbrec_logical_switch_port *lsp)
> >  {
> > -    return !lsp->up || *lsp->up;
> > +    return lsp->up && *lsp->up;
> >  }
> >
> >  static bool
> > --
> > 2.1.0
> >
> 
> Ben/Justin, this has been merged to OVN repo. Could you please backport to 2.12? Thanks.

Thanks, Han.  I pushed this to branch-2.12.

Han and Numan, I sent a follow up patch, which I think clarifies the code a bit (by using the "n_" member to check whether the column is set) and improves the documentation:

	https://patchwork.ozlabs.org/patch/1144879/

Can you take a look?

Thanks,

--Justin




More information about the dev mailing list