[ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

Yi-Hung Wei yihung.wei at gmail.com
Tue Aug 13 21:27:09 UTC 2019


On Tue, Aug 13, 2019 at 4:25 AM <aserdean at ovn.org> wrote:
> > ---
> >  Documentation/faq/releases.rst                     |   3 +-
> >  datapath-windows/include/OvsDpInterfaceCtExt.h     | 114 +++++
> >  datapath-windows/ovsext/Netlink/NetlinkProto.h     |   8 +-
> >  include/windows/automake.mk                        |   1 +
> >  .../windows/linux/netfilter/nfnetlink_cttimeout.h  |   0
> >  lib/ct-dpif.c                                      | 104 +++++
> >  lib/ct-dpif.h                                      |  56 +++
> >  lib/dpif-netdev.c                                  |   6 +
> >  lib/dpif-netlink.c                                 | 469
> +++++++++++++++++++++
> >  lib/dpif-netlink.h                                 |   1 -
> >  lib/dpif-provider.h                                |  44 ++
> >  lib/netlink-conntrack.c                            | 308 ++++++++++++++
> >  lib/netlink-conntrack.h                            |  27 +-
> >  lib/netlink-protocol.h                             |   8 +-
> >  14 files changed, 1142 insertions(+), 7 deletions(-)
> >  create mode 100644 include/windows/linux/netfilter/nfnetlink_cttimeout.h
> >
> [Alin] This is not an actual review.
>
> I'm okay with the Windows changes.
>
> I also tested the series and things look good.
>
> Do you mind folding in the following:
> diff --git a/datapath-windows/include/OvsDpInterfaceCtExt.h
> b/datapath-windows/include/OvsDpInterfaceCtExt.h
> index 4379855bb..3379f0a25 100644
> --- a/datapath-windows/include/OvsDpInterfaceCtExt.h
> +++ b/datapath-windows/include/OvsDpInterfaceCtExt.h
> @@ -421,7 +421,7 @@ struct nf_ct_tcp_flags {
>      UINT8 mask;
>  };
>
> -/* File: nfnetlink_cttimeout.h */
> +/* File: nfnetlink_cttimeout.h. XXX: the following are not implemented */
>  enum ctnl_timeout_msg_types {
>      IPCTNL_MSG_TIMEOUT_NEW,
>      IPCTNL_MSG_TIMEOUT_GET,
>
>
> Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
>

Thanks Alin!  Will fold in your diff into OvsDpInterfaceCtExt.h

Thanks,

-Yi-Hung


More information about the dev mailing list