[ovs-dev] [PATCH] dpif-netdev: Add core id in the PMD thread name.
david.marchand at redhat.com
Tue Aug 20 11:18:31 UTC 2019
On Tue, Aug 20, 2019 at 12:06 PM Ilya Maximets <i.maximets at samsung.com> wrote:
> On 20.08.2019 13:00, David Marchand wrote:
> > On Wed, Aug 14, 2019 at 9:45 AM Ilya Maximets <i.maximets at samsung.com> wrote:
> >> On 13.08.2019 19:46, Eelco Chaudron wrote:
> >>> This is a really good idea :) One remark should we make it %03d?
> >> There is a hard limit for the thread name. It's 15 meaningful chars excluding the
> >> terminating null byte. 'pmd-c02/id:' is 11 bytes wide keeping 4 bytes for the
> >> thread id. 'pmd-c002/id:' is 12 bytes wide with only 3 bytes remaining for id.
> >> Thread ids could easily become big ( > 1000) for a long running process, that is
> >> why %02d was chosen, to save some space.
> > Do we really need the /id: part?
> > A c%03d/pmd prefix would keep the existing pmd%d pattern and save 3 characters.
> This will break lib/ovs-thread.c:thread_is_pmd() function.
Ok, not really a problem to change from my pov.
I don't really like the /id: in the thread name, as usually userspace
thread names contains simple alphanumeric characters.
But I can see no problem with this so:
Reviewed-by: David Marchand <david.marchand at redhat.com>
More information about the dev