[ovs-dev] [PATCH v3 2/5] ovsdb-idl.c: Allows retry even when using a single remote.

Han Zhou zhouhan at gmail.com
Wed Aug 21 19:31:16 UTC 2019


On Wed, Aug 21, 2019 at 11:59 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Wed, Aug 21, 2019 at 11:27:58AM -0700, Ben Pfaff wrote:
> > On Wed, Aug 21, 2019 at 11:21:12AM -0700, Han Zhou wrote:
> > > On Wed, Aug 21, 2019 at 11:13 AM Ben Pfaff <blp at ovn.org> wrote:
> > > >
> > > > On Mon, Aug 19, 2019 at 09:29:57AM -0700, Han Zhou wrote:
> > > > > From: Han Zhou <hzhou8 at ebay.com>
> > > > >
> > > > > When clustered mode is used, the client needs to retry connecting
> > > > > to new servers when certain failures happen. Today it is allowed
to
> > > > > retry new connection only if multiple remotes are used, which
prevents
> > > > > using LB VIP with clustered nodes. This patch makes sure the retry
> > > > > logic works when using LB VIP: although same IP is used for
retrying,
> > > > > the LB can actually redirect the connection to a new node.
> > > > >
> > > > > Signed-off-by: Han Zhou <hzhou8 at ebay.com>
> > > > > ---
> > > > > v2 -> v3: Minor fix for test case.
> > > >
> > > > I see that I commented on v1 of this patch by mistake, but the same
> > > > comment applies here: please update the documentation to explain
the new
> > > > behavior.
> > >
> > > Hi Ben,
> > >
> > > Yes we agreed to update ovn-nb/sb documentation, but this patch
belongs to
> > > OVS repo and the documentation would belong to OVN repo. So we will
send
> > > update to documentation of ovn-nbctl/sbctl separately on OVN repo.
> >
> > OK.
> >
> > Do you want this patch backported to 2.12?
>
> I applied this series to master.  I haven't done any backports (besides
> patch 1, which is obviously a bug fix).  Let me know if you'd like any
> of the remaining patches backported.

Thanks Ben! Could you backport at least 1/5 - 4/5 to 2.12, so that the
stale leader problem and the is_connected() flapping problem are solved?
5/5 is purely an enhancement, but I'd be happy if it is backported, too,
since the feature is important to large scale use cases.

Thanks,
Han


More information about the dev mailing list