[ovs-dev] [PATCH v3 ovn 1/4] Build OVN using external OVS directory

0-day Robot robot at bytheb.org
Sat Aug 24 07:57:48 UTC 2019


Bleep bloop.  Greetings Numan Siddique, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 81 characters long (recommended limit is 79)
#143 FILE: .travis/osx-build.sh:31:
    export DISTCHECK_CONFIGURE_FLAGS="$EXTRA_OPTS --with-ovs-source=$PWD/ovs_src"

WARNING: Line is 97 characters long (recommended limit is 79)
#159 FILE: Documentation/intro/install/general.rst:46:
Please see the Open vSwitch documentation (https://docs.openvswitch.org/en/latest/intro/install/)

WARNING: Line is 85 characters long (recommended limit is 79)
#204 FILE: Documentation/intro/install/general.rst:292:
    $./configure --with-ovs-source=/home/foo/ovs/ --with-ovs-build=/home/foo/ovs/_gcc

WARNING: Line is 96 characters long (recommended limit is 79)
#1401 FILE: tutorial/ovs-sandbox:342:
    PATH=$ovsbuilddir/ovsdb:$ovsbuilddir/vswitchd:$ovsbuilddir/utilities:$ovsbuilddir/vtep:$PATH

WARNING: Line is 98 characters long (recommended limit is 79)
#1402 FILE: tutorial/ovs-sandbox:343:
    PATH=$builddir/controller:$builddir/controller-vtep:$builddir/northd:$builddir/utilities:$PATH

WARNING: Line is 87 characters long (recommended limit is 79)
#1591 FILE: tutorial/ovs-sandbox:476:
                    run ovsdb-tool create-cluster ${db}1.db "$schema" unix:${db}1.raft;

WARNING: Line is 102 characters long (recommended limit is 79)
#1593 FILE: tutorial/ovs-sandbox:478:
                    run ovsdb-tool join-cluster $db$i.db $schema_name unix:$db$i.raft unix:${db}1.raft

WARNING: Line is 106 characters long (recommended limit is 79)
#1653 FILE: tutorial/ovs-sandbox:525:
    ovn-nbctl set-ssl $sandbox/ovnnb-privkey.pem  $sandbox/ovnnb-cert.pem $sandbox/pki/switchca/cacert.pem

WARNING: Line is 106 characters long (recommended limit is 79)
#1655 FILE: tutorial/ovs-sandbox:527:
    ovn-sbctl set-ssl $sandbox/ovnsb-privkey.pem  $sandbox/ovnsb-cert.pem $sandbox/pki/switchca/cacert.pem

WARNING: Line is 120 characters long (recommended limit is 79)
#1682 FILE: tutorial/ovs-sandbox:534:
    OVN_CTRLR_PKI="-p $sandbox/chassis-1-privkey.pem -c $sandbox/chassis-1-cert.pem -C $sandbox/pki/switchca/cacert.pem"

Lines checked: 1724, Warnings: 10, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list