[ovs-dev] [PATCH ovn] Fix memory leak in build_pre_lb

Numan Siddique nusiddiq at redhat.com
Mon Aug 26 11:22:28 UTC 2019


On Sun, Aug 25, 2019 at 11:32 PM Lorenzo Bianconi <
lorenzo.bianconi at redhat.com> wrote:

> Fix memory leak of ip_address string in build_pre_lb routine if we
> install logical flows for empty_lb controller event
>
> Fixes: f49b17a6cbe3 ("OVN: use trigger_event action to report
> 'empty_lb_rule' events")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>
>

Thanks Lorenzo.
I applied this patch to ovn master.

Numan


> ---
>  northd/ovn-northd.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
> index e29b0fff4..ca128c996 100644
> --- a/northd/ovn-northd.c
> +++ b/northd/ovn-northd.c
> @@ -4063,7 +4063,6 @@ build_pre_lb(struct ovn_datapath *od, struct hmap
> *lflows)
>                                ds_cstr(&match), action);
>                  ds_destroy(&match);
>                  free(action);
> -                continue;
>              }
>
>              free(ip_address);
> --
> 2.21.0
>
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>


More information about the dev mailing list