[ovs-dev] [PATCH ovn v1] northd: Remove misleading warning log message

Russell Bryant russell at ovn.org
Mon Dec 2 03:22:01 UTC 2019


While debugging an ovn-kubernetes cluster, I spotted several
"Duplicate MAC set" warning messages in the ovn-northd log.  It looks
like this message was emitted from this code path by mistake, where
it correctly avoided assigning a duplicate MAC address.  This patch
turns off the warning for that case.

Signed-off-by: Russell Bryant <russell at ovn.org>
---
 northd/ovn-northd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c
index a943e1037..9f558c628 100644
--- a/northd/ovn-northd.c
+++ b/northd/ovn-northd.c
@@ -1395,7 +1395,7 @@ ipam_get_unused_mac(ovs_be32 ip)
         mac_addr_suffix = ((base_addr + i) % (MAC_ADDR_SPACE - 1)) + 1;
         mac64 =  eth_addr_to_uint64(mac_prefix) | mac_addr_suffix;
         eth_addr_from_uint64(mac64, &mac);
-        if (!ipam_is_duplicate_mac(&mac, mac64, true)) {
+        if (!ipam_is_duplicate_mac(&mac, mac64, false)) {
             break;
         }
     }
-- 
2.23.0



More information about the dev mailing list