[ovs-dev] [RFC PATCH] netdev-dpdk: Narrow down txq critical section.

David Marchand david.marchand at redhat.com
Tue Dec 3 12:40:25 UTC 2019


On Tue, Dec 3, 2019 at 12:17 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> On 02.12.2019 17:24, David Marchand wrote:
> > tx_lock protects the NIC/vhost queue from concurrent access.
> > Move it closer to the parts it protects and let packets duplication (when
> > source is not DPDK) and the egress policer run out of it.
> >
> > Signed-off-by: David Marchand <david.marchand at redhat.com>
> > ---
> > I caught this by code review, but I imagine this could make the
> > contention on the tx lock even worse if broadcasting packets.
>
> Idea is OK, I think.  I didn't look a t the code, but, IIRC, there was
> already a similar patch in a mail-list.. Hard to find.

Ah indeed, I found this:
https://mail.openvswitch.org/pipermail/ovs-dev/2019-January/355743.html
But I did not find it in patchwork, not sure why, copied its author.

My RFC patch goes one step further, since it also moves the
allocations out of the lock.


--
David Marchand



More information about the dev mailing list