[ovs-dev] [PATCH ovn] system-ovn.at: check HAVE_TCPDUMP in "2 LSs IGMP" test

Dumitru Ceara dceara at redhat.com
Thu Dec 5 14:39:31 UTC 2019


On Thu, Dec 5, 2019 at 11:42 AM Lorenzo Bianconi
<lorenzo.bianconi at redhat.com> wrote:
>
> Do not run "2 LSs IGMP" unitest if tcpdump is not currently installed on
> the machine
>
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi at redhat.com>

Thanks Lorenzo for the patch. It looks good to me.

Acked-by: Dumitru Ceara <dceara at redhat.com>

> ---
>  tests/system-ovn.at | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/system-ovn.at b/tests/system-ovn.at
> index dbff58f24..bf598aec5 100644
> --- a/tests/system-ovn.at
> +++ b/tests/system-ovn.at
> @@ -3128,6 +3128,7 @@ OVS_TRAFFIC_VSWITCHD_STOP(["/failed to query port patch-.*/d
>  AT_CLEANUP
>
>  AT_SETUP([ovn -- 2 LSs IGMP])
> +AT_SKIP_IF([test $HAVE_TCPDUMP = no])
>  AT_KEYWORDS([ovnigmp])
>
>  ovn_start
> --
> 2.21.0
>



More information about the dev mailing list