[ovs-dev] [PATCH V3 08/19] netdev-offload-dpdk: Protect UFID map by mutex

Eli Britstein elibr at mellanox.com
Tue Dec 10 14:56:10 UTC 2019


On 12/10/2019 4:53 PM, Ilya Maximets wrote:
> On 08.12.2019 14:22, Eli Britstein wrote:
>> Flow deletion and dumping for statistics collection are called from
>> different threads. As a pre-step towards collecting HW statistics,
>> protect the UFID map by mutex to make it thread safe.
>>
>> Signed-off-by: Eli Britstein <elibr at mellanox.com>
>> ---
>>   lib/netdev-offload-dpdk.c | 7 ++++++-
>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>
> This patch is not needed as you have to hold global datapath port
> mutex while calling netdev-offload-dpdk functions.  This module
> is not thread safe at all.
>
> See https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F1207077%2F&data=02%7C01%7Celibr%40mellanox.com%7C25748aeece0d4a07a10408d77d80b937%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637115864133577751&sdata=ndq%2Fda30D1ih4AaUmLvfFmVwXfcTO9hr5Y7wyM6KOzs%3D&reserved=0 .
That's right, but in next commits, reading the stats using 
netdev_flow_get is done from another thread. This commit is a pre-step 
towards it. see the commit msg.
>
> Best regards, Ilya Maximets.


More information about the dev mailing list