[ovs-dev] [PATCH V3 07/19] netdev-dpdk: Introduce rte flow query function

[Ilya Maximets]

On 10.12.2019 15:53, Eli Britstein wrote:
> 
> On 12/10/2019 4:50 PM, Ilya Maximets wrote:
>> On 08.12.2019 14:22, Eli Britstein wrote:
>>> Introduce a rte flow query function as a pre-step towards reading HW
>>> statistics of fully offloaded flows.
>>>
>>> Signed-off-by: Eli Britstein <elibr at mellanox.com>
>>> Reviewed-by: Oz Shlomo <ozsh at mellanox.com>
>>> ---
>>>   lib/netdev-dpdk.c | 25 +++++++++++++++++++++++++
>>>   lib/netdev-dpdk.h |  6 ++++++
>>>   2 files changed, 31 insertions(+)
>>>
>>> diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c
>>> index da1349b69..e63a496c1 100644
>>> --- a/lib/netdev-dpdk.c
>>> +++ b/lib/netdev-dpdk.c
>>> @@ -4737,6 +4737,31 @@ netdev_dpdk_rte_flow_create(struct netdev *netdev,
>>>       return flow;
>>>   }
>>>   
>>> +int
>>> +netdev_dpdk_rte_flow_query(struct netdev *netdev,
>> Shouldn't it be named netdev_dpdk_rte_flow_query_count() ?
> it's a paraphrase of "rte_flow_query()" (DPDK API), and it can stay as 
> is if changed beyond "count" usage in the future, but OK.

You'll need to change the function prototype anyway.