[ovs-dev] [PATCH] bridge: Allow manual notifications about interfaces' updates.

[Ilya Maximets]

On 17.12.2019 19:39, Ilya Maximets wrote:
> On 17.12.2019 19:25, Ben Pfaff wrote:
>> On Tue, Dec 17, 2019 at 02:45:03PM +0100, Eelco Chaudron wrote:
>>>
>>>
>>> On 6 Nov 2019, at 14:32, Eelco Chaudron wrote:
>>>
>>>> On 5 Nov 2019, at 18:20, Ilya Maximets wrote:
>>>>
>>>>> Sometimes interface updates could happen in a way ifnotifier is not
>>>>> able to catch.  For example some heavy operations (device reset) in
>>>>> netdev-dpdk could require re-applying of the bridge configuration.
>>>>>
>>>>> For this purpose new manual notifier introduced. Its function
>>>>> 'if_notifier_manual_report()' could be called directly by the code
>>>>> that aware about changes.  This new notifier is thread-safe.
>>>>>
>>>>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>>>>
>>>> Reviewed and tested this patch in combination with the “netdev-dpdk: add
>>>> support for the RTE_ETH_EVENT_INTR_RESET event”.
>>>>
>>>> LGTM,
>>>>
>>>> Acked-by: Eelco Chaudron <echaudro at redhat.com>
>>>
>>> Is there anything waiting to get this included so my other patch could get
>>> included?
>>
>> Seems reasonable.  The only thing I noticed in it is two function
>> definitions where the function name should be moved to the beginning of
>> a line.
> 
> Thanks for spotting.  Will fix before applying.
> 
>>
>> Ilya, I'm assuming you'll apply it when you're satisfied?
> 
> I'm taking the last look at the dependent patch
> https://patchwork.ozlabs.org/patch/1192944/
> It seems OK so far and I'm going to apply both patches soon.
> 
> Best regards, Ilya Maximets.
> 

Thanks Eelco and Ben.  Fixed and applied.

Best regards, Ilya Maximets.