[ovs-dev] [PATCH 3/3] system-afxdp.at: Add test for infinite re-addition of failed ports.

Ilya Maximets i.maximets at ovn.org
Wed Dec 18 00:34:35 UTC 2019


On 09.12.2019 21:42, William Tu wrote:
> On Sat, Dec 07, 2019 at 03:46:18PM +0100, Ilya Maximets wrote:
>> New file created for AF_XDP specific tests.
>>
>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> tested and LGTM, one minor comment.
> 
> Acked-by: William Tu <u9012063 at gmail.com>
>> ---
>>  tests/automake.mk               |  3 ++-
>>  tests/system-afxdp-testsuite.at |  1 +
>>  tests/system-afxdp.at           | 24 ++++++++++++++++++++++++
>>  3 files changed, 27 insertions(+), 1 deletion(-)
>>  create mode 100644 tests/system-afxdp.at
>>
>> diff --git a/tests/automake.mk b/tests/automake.mk
>> index 4bf8f00d5..529eab54e 100644
>> --- a/tests/automake.mk
>> +++ b/tests/automake.mk
>> @@ -156,7 +156,8 @@ SYSTEM_USERSPACE_TESTSUITE_AT = \
>>  SYSTEM_AFXDP_TESTSUITE_AT = \
>>  	tests/system-userspace-macros.at \
>>  	tests/system-afxdp-testsuite.at \
>> -	tests/system-afxdp-macros.at
>> +	tests/system-afxdp-macros.at \
>> +	tests/system-afxdp.at
>>  
>>  SYSTEM_TESTSUITE_AT = \
>>  	tests/system-common-macros.at \
>> diff --git a/tests/system-afxdp-testsuite.at b/tests/system-afxdp-testsuite.at
>> index 9b7a29066..22fecf063 100644
>> --- a/tests/system-afxdp-testsuite.at
>> +++ b/tests/system-afxdp-testsuite.at
>> @@ -24,3 +24,4 @@ m4_include([tests/system-userspace-macros.at])
>>  m4_include([tests/system-afxdp-macros.at])
>>  
>>  m4_include([tests/system-traffic.at])
>> +m4_include([tests/system-afxdp.at])
> should we move system-afxdp.at before system-traffic?
> So these more basic test cases get triggered first.

This might make sense.  I thought about this before sending the patch.
Will change before applying.


More information about the dev mailing list