[ovs-dev] [PATCH v3] ovsdb replication: Provide option to configure probe interval.
Ben Pfaff
blp at ovn.org
Thu Dec 19 18:58:15 UTC 2019
On Fri, Dec 13, 2019 at 03:15:36PM -0500, numans at ovn.org wrote:
> From: Numan Siddique <numans at ovn.org>
>
> When ovsdb-server is in backup mode and connects to the active
> ovsdb-server for replication, and if takes more than 5 seconds to
> get the dump of the whole database, it will drop the connection
> soon after as the default probe interval is 5 seconds. This
> results in a snowball effect of reconnections to the active
> ovsdb-server.
>
> This patch handles or mitigates this issue by setting the
> default probe interval value to 60 seconds and provide the option to
> configure this value from the unixctl command.
>
> Other option could be increase the value of 'RECONNECT_DEFAULT_PROBE_INTERVAL'
> to a higher value.
>
> Acked-by: Mark Michelson <mmichels at redhat.com>
> Signed-off-by: Numan Siddique <numans at ovn.org>
Thanks for the patch! I have a couple of comments.
In the documentation, please put \ before - consistently in the .IP.
When it's possible, I like settings to take effect immediately, so that
users don't have to restart things. I think that this should be
possible here, by calling jsonrpc_session_set_probe_interval() in the
right place. Did you look at what it would take?
Thanks,
Ben.
More information about the dev
mailing list