[ovs-dev] [PATCH v3] ovsdb replication: Provide option to configure probe interval.

[Numan Siddique]

On Fri, Dec 20, 2019 at 12:28 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Fri, Dec 13, 2019 at 03:15:36PM -0500, numans at ovn.org wrote:
> > From: Numan Siddique <numans at ovn.org>
> >
> > When ovsdb-server is in backup mode and connects to the active
> > ovsdb-server for replication, and if takes more than 5 seconds to
> > get the dump of the whole database, it will drop the connection
> > soon after as the default probe interval is 5 seconds. This
> > results in a snowball effect of reconnections to the active
> > ovsdb-server.
> >
> > This patch handles or mitigates this issue by setting the
> > default probe interval value to 60 seconds and provide the option to
> > configure this value from the unixctl command.
> >
> > Other option could be increase the value of 'RECONNECT_DEFAULT_PROBE_INTERVAL'
> > to a higher value.
> >
> > Acked-by: Mark Michelson <mmichels at redhat.com>
> > Signed-off-by: Numan Siddique <numans at ovn.org>
>
> Thanks for the patch!  I have a couple of comments.
>
> In the documentation, please put \ before - consistently in the .IP.
>
> When it's possible, I like settings to take effect immediately, so that
> users don't have to restart things.  I think that this should be
> possible here, by calling jsonrpc_session_set_probe_interval() in the
> right place.  Did you look at what it would take?
>

Thanks  for the review. I have submitted v4 addressing the comments -
https://patchwork.ozlabs.org/patch/1214081/

I thought about that, but I wasn't sure if it's a good idea to set the
probe interval
in the unixctl command handler. v4 which I just submitted, sets the
probe interval in the command
handler though.

Thanks
Numan


> Thanks,
>
> Ben.
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>