[ovs-dev] [PATCH v6 07/10] netdev-offload-tc: Add recirculation support via tc chains

[Paul Blakey]

V7 is up, sorrty about that.
________________________________
From: Simon Horman <simon.horman at netronome.com>
Sent: Thursday, December 19, 2019 10:27 PM
To: Paul Blakey <paulb at mellanox.com>
Cc: Roi Dayan <roid at mellanox.com>; Oz Shlomo <ozsh at mellanox.com>; Marcelo Ricardo Leitner <mleitner at redhat.com>; Justin Pettit <jpettit at nicira.com>; Ilya Maximets <i.maximets at ovn.org>; Ben Pfaff <blp at ovn.org>; dev at openvswitch.org <dev at openvswitch.org>
Subject: Re: [ovs-dev][ovs-dev][PATCH v6 07/10] netdev-offload-tc: Add recirculation support via tc chains

On Thu, Dec 19, 2019 at 04:57:37PM +0200, Paul Blakey wrote:
> Each recirculation id will create a tc chain, and we translate
> the recirculation action to a tc goto chain action.
>
> We check for kernel support for this by probing OvS Datapath for the
> tc recirc id sharing feature. If supported, we can offload rules
> that match on recirc_id, and recirculation action safely.
>
> Signed-off-by: Paul Blakey <paulb at mellanox.com>
> Reviewed-by: Roi Dayan <roid at mellanox.com>

...

> @@ -1427,6 +1443,11 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match,
>          }
>      }
>
> +    if ((chain || recirc_act) && !info.recirc_id_shared_with_tc) {

Hi Paul,

Travis is a reporting an error on this line, pehaps 'info.' should be 'info->' ?

https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftravis-ci.org%2Fhorms2%2Fovs%2Fjobs%2F627292953%23L1391&data=02%7C01%7Cpaulb%40mellanox.com%7Ce05baf3967c74c2b745008d784c1d26c%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C637123840305692270&sdata=FeEL7bcYJLovSBecMLjOaIjsE8Dkf4k0b019vpkvr5Y%3D&reserved=0

> +        VLOG_ERR_RL(&error_rl, "flow_put: recirc_id sharing not supported");
> +        return EOPNOTSUPP;
> +    }
> +
>      if (get_ufid_tc_mapping(ufid, &id) == 0) {
>          VLOG_DBG_RL(&rl, "updating old handle: %d prio: %d",
>                      id.handle, id.prio);
>

...