[ovs-dev] 答复: [PATCH] conntrack: compute hash value once when calling conn_key_lookup

Li,Rongqing lirongqing at baidu.com
Fri Feb 1 08:49:39 UTC 2019



发件人: Darrell Ball [mailto:dlu998 at gmail.com] 
发送时间: 2019年2月1日 16:25
收件人: Li,Rongqing <lirongqing at baidu.com>
抄送: ovs dev <dev at openvswitch.org>
主题: Re: [ovs-dev] [PATCH] conntrack: compute hash value once when calling conn_key_lookup

> The function comment says it all:
> /* Typical usage of this helper is in non per-packet code;
> * this is because the bucket lock needs to be held for lookup
> * and a hash would have already been needed. Hence, this function
> * is just intended for code clarity. */
> 

Does it mean that the hash value will be changed ?  if it is true, should we release original lock, and relock lock for new hash value?

Thanks

-RongQing


More information about the dev mailing list