[ovs-dev] 答复: [PATCH] conntrack: Remove unnecessary check in process_ftp_ctl_v4

Li,Rongqing lirongqing at baidu.com
Fri Feb 1 09:07:49 UTC 2019



发件人: Darrell Ball [mailto:dlu998 at gmail.com] 
发送时间: 2019年2月1日 16:15
收件人: Li,Rongqing <lirongqing at baidu.com>
抄送: ovs dev <dev at openvswitch.org>
主题: Re: [ovs-dev] [PATCH] conntrack: Remove unnecessary check in process_ftp_ctl_v4


>This was intentionally done to be documentative and also make it hard to break;
>this code path sees a tiny number of packets. 
>I am not sure there is much to gain by removing it and adding in lieu of comments ?
 
 
gain for packets is little, but step by step.

And  it can reduce unnessesary codes, make a newbie to easy study

Thanks

-RongQing 




More information about the dev mailing list