[ovs-dev] [PATCH v2] ovs-tcpdump: Fix an undefined variable

[Aaron Conole]

Ilya Maximets <i.maximets at samsung.com> writes:

>> Run ovs-tcpdump without --span, and it throws the following
>> exception. Define mirror_select_all to avoid the error.
>> 
>> Traceback (most recent call last):
>>   File "/usr/local/bin/ovs-tcpdump", line 488, in <module>
>>     main()
>>   File "/usr/local/bin/ovs-tcpdump", line 454, in main
>>     mirror_select_all)
>> UnboundLocalError: local variable 'mirror_select_all' referenced before assignment
>> 
>> Fixes: 0475db71c650 ("ovs-tcpdump: Add --span to mirror all ports on bridge.")
>> 
>> Signed-off-by: Hyong Youb Kim <hyonkim at cisco.com>
>> ---
>> v2:
>> * fix a typo: with -> without
>> * resend after subscribing to dev to avoid ovs-dev in From:
>> 
>>  utilities/ovs-tcpdump.in | 1 +
>>  1 file changed, 1 insertion(+)
>
> Thanks for the fix,
> Acked-by: Ilya Maximets <i.maximets at samsung.com>
>
> Regarding checkpatch. Looks like it's a patchwork issue.
> It has mail-list email in a form field. Mail-list itself shows correct e-mail.
> I hope, maintainers will use correct one while applying the patch, if needed.

I don't see that the email address is correct.  Actually in my email
client, it does say:

   From: Hyong Youb Kim via dev <ovs-dev at openvswitch.org>

I'm not sure what causes this (again, I'm going from the email I
received), but we've seen it before.

> Another option (workaround): You may add "From: Name <e-mail>" as a first line
> of the commit-message. This should be correctly treated by git in any case.

Also, you can try attaching the patch to an email to the list (I think
that can work), or submitting a pull request on github and sending the
list an email with the information.

Very strange, though.

>> diff --git a/utilities/ovs-tcpdump.in b/utilities/ovs-tcpdump.in
>> index 22f249f58..269c252f8 100755
>> --- a/utilities/ovs-tcpdump.in
>> +++ b/utilities/ovs-tcpdump.in
>> @@ -379,6 +379,7 @@  def main():
>>  
>>      skip_next = False
>>      mirror_interface = None
>> +    mirror_select_all = False
>>      dump_cmd = 'tcpdump'
>>  
>>      for cur, nxt in argv_tuples(sys.argv[1:]):
>>