[ovs-dev] [PATCH] acinclude: Drop DPDK_EXTRA_LIB variable.
Ian Stokes
ian.stokes at intel.com
Thu Feb 7 15:51:11 UTC 2019
On 2/7/2019 12:20 PM, Ilya Maximets wrote:
> AC_SEARCH_LIBS enables the libraries itself:
>
> checking for library containing get_mempolicy... -lnuma
> checking for library containing pcap_dump... -lpcap
>
> So, they are available in LIBS. No need to add them twice.
>
> Also, DPDK_EXTRA_LIB doesn't even work, because each check overwrites
> the variable instead of appending the new library. It was first time
> misused while making libnuma optional and copy-pasted to several places
> after that.
>
Good catch, wasn't aware that the libs were added automatically by
search, good to know.
I've applied to master and backported to 2.7
Ian
More information about the dev
mailing list