[ovs-dev] [PATCH] acinclude: Use NUMA_AWARE_HUGEPAGES too for libnuma check.

Ian Stokes ian.stokes at intel.com
Thu Feb 7 16:18:41 UTC 2019


On 2/7/2019 1:00 PM, Ilya Maximets wrote:
> This fixes build with NUMA_AWARE_HUGEPAGES enabled and VHOST_NUMA
> disabled. This should not be a usual case. But it's possible to
> configure DPDK this way.
> 

Out of interest, with RTE_EAL_NUMA_AWARE_HUGEPAGES defined but not 
RTE_LIBRTE_VHOST_NUMA, does vhost numa still work as expected?

Ian
> Fixes: 5e925ccc2a6f ("netdev-dpdk: DPDK v17.11 upgrade")
> 
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---
>   acinclude.m4 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/acinclude.m4 b/acinclude.m4
> index c51af246a..e2af4ee16 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -254,7 +254,7 @@ AC_DEFUN([OVS_CHECK_DPDK], [
>         AC_LANG_PROGRAM(
>           [
>             #include <rte_config.h>
> -#if RTE_LIBRTE_VHOST_NUMA
> +#if defined(RTE_LIBRTE_VHOST_NUMA) || defined(RTE_EAL_NUMA_AWARE_HUGEPAGES)
>   #error
>   #endif
>           ], [])
> 



More information about the dev mailing list