[ovs-dev] odp-util: Do not rewrite fields with the same values as matched

0-day Robot robot at bytheb.org
Thu Feb 7 17:02:34 UTC 2019


Bleep bloop.  Greetings Eli Britstein, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
ERROR: Inappropriate bracing around statement
#57 FILE: lib/odp-util.c:7189:
        if (size == 0)

ERROR: Inappropriate bracing around statement
#60 FILE: lib/odp-util.c:7192:
        if (memcmp(pkey0, pkey1, size) == 0)

ERROR: Inappropriate bracing around statement
#62 FILE: lib/odp-util.c:7194:
        else

WARNING: Line is 92 characters long (recommended limit is 79)
#85 FILE: lib/odp-util.c:7250:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ethernet, name), sizeof(type)},

WARNING: Line is 88 characters long (recommended limit is 79)
#108 FILE: lib/odp-util.c:7393:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv4, name), sizeof(type)},

WARNING: Line is 88 characters long (recommended limit is 79)
#130 FILE: lib/odp-util.c:7454:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv6, name), sizeof(type)},

WARNING: Line is 87 characters long (recommended limit is 79)
#152 FILE: lib/odp-util.c:7514:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_arp, name), sizeof(type)},

WARNING: Line is 88 characters long (recommended limit is 79)
#173 FILE: lib/odp-util.c:7555:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_icmp, name), sizeof(type)},

WARNING: Line is 86 characters long (recommended limit is 79)
#196 FILE: lib/odp-util.c:7626:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_nd, name), sizeof(type)},

WARNING: Line is 87 characters long (recommended limit is 79)
#217 FILE: lib/odp-util.c:7877:
#define __OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_tcp, name), sizeof(type)},

Lines checked: 353, Warnings: 7, Errors: 3


build:
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/odp-execute.lo -MD -MP -MF lib/.deps/odp-execute.Tpo -c lib/odp-execute.c -o lib/odp-execute.o
depbase=`echo lib/odp-util.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
/bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/odp-util.lo -MD -MP -MF $depbase.Tpo -c -o lib/odp-util.lo lib/odp-util.c &&\
mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/odp-util.lo -MD -MP -MF lib/.deps/odp-util.Tpo -c lib/odp-util.c -o lib/odp-util.o
lib/odp-util.c: In function 'commit_set_nd_extensions_action':
lib/odp-util.c:7659:16: error: passing argument 7 of 'commit' from incompatible pointer type [-Werror]
                &base, &mask, sizeof key, odp_actions)) {
                ^
lib/odp-util.c:7202:1: note: expected 'struct ovs_key_field_properties *' but argument is of type 'struct ofpbuf *'
 commit(enum ovs_key_attr attr, bool use_masked_set,
 ^
lib/odp-util.c:7659:16: error: too few arguments to function 'commit'
                &base, &mask, sizeof key, odp_actions)) {
                ^
lib/odp-util.c:7202:1: note: declared here
 commit(enum ovs_key_attr attr, bool use_masked_set,
 ^
cc1: all warnings being treated as errors
make[2]: *** [lib/odp-util.lo] Error 1
make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
make: *** [all] Error 2


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list