[ovs-dev] [PATCH v3 1/1] acinclude: Also use LIBS from dpkg pkg-config

[Christian Ehrhardt]

On Fri, Feb 8, 2019 at 4:55 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Thu, Feb 07, 2019 at 12:00:39PM +0100, Christian Ehrhardt wrote:
> > [...]
> >
> > >      case "$with_dpdk" in
> > >        yes)
> > >          DPDK_AUTO_DISCOVER="true"
> > > -        PKG_CHECK_MODULES([DPDK], [libdpdk],
> > > -                          [DPDK_INCLUDE="$DPDK_CFLAGS"],
> > > -                          [DPDK_INCLUDE="-I/usr/local/include/dpdk -I/usr/include/dpdk"])
> > > +        PKG_CHECK_MODULES_STATIC([DPDK], [libdpdk],
> > > +                                 [DPDK_INCLUDE="$DPDK_CFLAGS", DPDK_LIB="$DPDK_LIBS"],
> > > +                                 [DPDK_INCLUDE="-I/usr/local/include/dpdk -I/usr/include/dpdk", DPDK_LIB="-ldpdk"])
> > >          ;;
> > >        *)
> > >          DPDK_AUTO_DISCOVER="false"
> >
> > While working fine in all my builds (and it seems on travis now) I got
> > reports of the statements above creating a colon in the assignment on
> > some builds - thanks James (on CC now).
> > It was adding a trailing colon to the FLAGS which broke his build.
> >
> > I wanted to ask the more experienced autoconf users if that makes any sense?
>
> I don't see any colons above.  I do see commas.

commas I meant, sorry :-/

> They look weird to me.
> In Bourne shell, spaces are used to separate assignments, not commas.  I
> would remove them.
>
> Other white space, like new-lines, works too.

Thanks Ben,
in V4 sent yesterday I used newlines - so that should be good now I hope.