[ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

Ben Pfaff blp at ovn.org
Tue Feb 12 03:43:10 UTC 2019


On Mon, Feb 04, 2019 at 04:23:07PM -0800, Darrell Ball wrote:
> 'conn_key_extract()' in userspace conntrack is including L2
> (Ethernet) pad bytes for both L3 and L4 sizes. One problem is
> any packet with non-zero L2 padding can incorrectly fail L4
> checksum validation.
> 
> This patch fixes conn_key_extract() by ignoring L2 pad bytes.
> 
> Fixes: a489b16854b5 ("conntrack: New userspace connection tracker.")
> CC: Daniele Di Proietto <diproiettod at ovn.org>
> Co-authored-by: Vishal Deep Ajmera <vishal.deep.ajmera at ericsson.com>
> Co-authored-by: Venkatesan Pradeep <venkatesan.pradeep at ericsson.com>
> Co-authored-by: Nitin Katiyar <nitin.katiyar at ericsson.com>
> Signed-off-by: Vishal Deep Ajmera <vishal.deep.ajmera at ericsson.com>
> Signed-off-by: Venkatesan Pradeep <venkatesan.pradeep at ericsson.com>
> Signed-off-by: Nitin Katiyar <nitin.katiyar at ericsson.com>
> Signed-off-by: Darrell Ball <dlu998 at gmail.com>

Thanks.

I applied this series to master.  Please let me know what branches I
should backport it to.


More information about the dev mailing list