[ovs-dev] [PATCH v5 1/1] acinclude: Also use LIBS from dpkg pkg-config

Christian Ehrhardt christian.ehrhardt at canonical.com
Tue Feb 12 06:28:17 UTC 2019


On Tue, Feb 12, 2019 at 2:52 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Mon, Feb 11, 2019 at 08:36:47PM +0100, Christian Ehrhardt wrote:
> > DPDK 18.11 builds using the more modern meson build system no more
> > provide the -ldpdk linker script. Instead it is expected to use
> > pkgconfig for linker options as well.
> >
> > This change will set DPDK_LIB from pkg-config (if pkg-config was
> > available) and since that already carries the whole-archive flags
> > around the PMDs skips the further wrapping in more whole-archive
> > if that is already part of DPDK_LIB.
> >
> > To work reliable in all environments this needs pkg-config 0.29.1.
> > We want to be able to use PKG_CHECK_MODULES_STATIC which
> > is not yet available in 0.24. Therefore update pkg.m4
> > to pkg-config 0.29.1.
> >
> > This should be backport-safe as these macro files are all versioned.
> > autoconf is smart enough to check the version if you have it locally,
> > and if the system's is higher, it will use that one instead.
> >
> > Acked-by: Luca Boccassi <bluca at debian.org>
> > Acked-by: Aaron Conole <aconole at redhat.com>
> > Signed-off-by: Christian Ehrhardt <christian.ehrhardt at canonical.com>
>
> Like the robot, I wasn't able to apply this.  I guess it needs a rebase.

I rebased minutes before I sent it, but by accident to "another"
master branch I from another remote :-)
But anyway, we are already at V5 so a V6 isn't far away

> Thank you!



-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd


More information about the dev mailing list