[ovs-dev] [PATCH] acinclude: Check for rte_config.h before checking dependencies.

Ian Stokes ian.stokes at intel.com
Tue Feb 12 17:12:06 UTC 2019


On 2/12/2019 1:19 PM, Ilya Maximets wrote:
> Current ./configure script shows misleading errors in case of wrong
> DPDK path:
> 
>    # ./configure --with-dpdk=/wrong/path
>    ...
>    checking whether dpdk datapath is enabled... yes
>    checking for library containing get_mempolicy... -lnuma
>    checking for library containing pcap_dump... -lpcap
>    checking for library containing mnl_attr_put... no
>    configure: error: unable to find libmnl, install the dependency package
> 
> This happens because we're not checking for headers before checking
> for dependencies. All the compile attempts fails and script thinks
> that we need more dependencies.
> 
> With this change script will check for 'rte_config.h' availability
> and produce sane error message:
> 
>    # ./configure --with-dpdk=/wrong/path
>    ...
>    checking for rte_config.h... no
>    configure: error: unable to find rte_config.h in /wrong/path
> 
> 'AC_INCLUDES_DEFAULT' passed explicitly to avoid preprocessor test.
> 
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> ---

Makes sense, thanks for this Ilya, applied to master.

Ian


More information about the dev mailing list