[ovs-dev] ovsdb-idl.c: Support monitor_cond_since method in C IDL.

[Han Zhou]

On Fri, Feb 15, 2019 at 11:15 AM 0-day Robot <robot at bytheb.org> wrote:
>
> Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
> Thanks for your contribution.
>
> I encountered some error that I wasn't expecting.  See the details below.
>
>
> build:
> depbase=`echo lib/ovsdb-data.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/ovsdb-data.lo -MD -MP -MF $depbase.Tpo -c -o lib/ovsdb-data.lo lib/ovsdb-data.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/ovsdb-data.lo -MD -MP -MF lib/.deps/ovsdb-data.Tpo -c lib/ovsdb-data.c -o lib/ovsdb-data.o
> depbase=`echo lib/ovsdb-error.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/ovsdb-error.lo -MD -MP -MF $depbase.Tpo -c -o lib/ovsdb-error.lo lib/ovsdb-error.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/ovsdb-error.lo -MD -MP -MF lib/.deps/ovsdb-error.Tpo -c lib/ovsdb-error.c -o lib/ovsdb-error.o
> depbase=`echo lib/ovsdb-idl.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
> /bin/sh ./libtool  --tag=CC   --mode=compile gcc -std=gnu99 -DHAVE_CONFIG_H -I.    -I ./include -I ./include -I ./lib -I ./lib    -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror   -g -O2 -MT lib/ovsdb-idl.lo -MD -MP -MF $depbase.Tpo -c -o lib/ovsdb-idl.lo lib/ovsdb-idl.c &&\
> mv -f $depbase.Tpo $depbase.Plo
> libtool: compile:  gcc -std=gnu99 -DHAVE_CONFIG_H -I. -I ./include -I ./include -I ./lib -I ./lib -Wstrict-prototypes -Wall -Wextra -Wno-sign-compare -Wpointer-arith -Wformat -Wformat-security -Wswitch-enum -Wunused-parameter -Wbad-function-cast -Wcast-align -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-field-initializers -fno-strict-aliasing -Wshadow -Werror -Werror -g -O2 -MT lib/ovsdb-idl.lo -MD -MP -MF lib/.deps/ovsdb-idl.Tpo -c lib/ovsdb-idl.c -o lib/ovsdb-idl.o
> lib/ovsdb-idl.c: In function 'ovsdb_idl_db_parse_monitor_reply':
> lib/ovsdb-idl.c:2113:21: error: unused variable 'last_id' [-Werror=unused-variable]
>          const char *last_id = json_string(result->array.elems[1]);
>                      ^
> lib/ovsdb-idl.c:2112:14: error: unused variable 'found' [-Werror=unused-variable]
>          bool found = json_boolean(result->array.elems[0]);
>               ^
> cc1: all warnings being treated as errors
> make[2]: *** [lib/ovsdb-idl.lo] Error 1
> make[2]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/var/lib/jenkins/jobs/upstream_build_from_pw/workspace'
> make: *** [all] Error 2
>
>
> Please check this out.  If you feel there has been an error, please email aconole at bytheb.org
>
> Thanks,
> 0-day Robot

Oops, these variables are needed only in next patch in the series.
Corrected in V2.