[ovs-dev] odp-util: Do not rewrite fields with the same values as matched

0-day Robot robot at bytheb.org
Sun Feb 17 10:04:13 UTC 2019


Bleep bloop.  Greetings Eli Britstein, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 90 characters long (recommended limit is 79)
#87 FILE: lib/odp-util.c:7252:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ethernet, name), sizeof(type)},

WARNING: Line is 86 characters long (recommended limit is 79)
#110 FILE: lib/odp-util.c:7395:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv4, name), sizeof(type)},

WARNING: Line is 86 characters long (recommended limit is 79)
#132 FILE: lib/odp-util.c:7456:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_ipv6, name), sizeof(type)},

WARNING: Line is 85 characters long (recommended limit is 79)
#154 FILE: lib/odp-util.c:7516:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_arp, name), sizeof(type)},

WARNING: Line is 86 characters long (recommended limit is 79)
#175 FILE: lib/odp-util.c:7557:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_icmp, name), sizeof(type)},

WARNING: Line is 84 characters long (recommended limit is 79)
#198 FILE: lib/odp-util.c:7628:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_nd, name), sizeof(type)},

WARNING: Line is 95 characters long (recommended limit is 79)
#219 FILE: lib/odp-util.c:7656:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_nd_extensions, name), sizeof(type)},

WARNING: Line is 85 characters long (recommended limit is 79)
#241 FILE: lib/odp-util.c:7885:
#define OVS_KEY_FIELD(type, name) {offsetof(struct ovs_key_tcp, name), sizeof(type)},

Lines checked: 377, Warnings: 8, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at bytheb.org

Thanks,
0-day Robot


More information about the dev mailing list