[ovs-dev] Meson integration for DPDK library

[Luca Boccassi]

Yes - but as I mentioned, there is no need to hard-code such a check in
the autoconf files.

Just call:

./configure PKG_CONFIG_PATH=path/to/wherever

On Tue, 2019-02-19 at 12:16 +0100, Daniele Rondina wrote:
> Currently, acinclude.m4 doesn't include a way to define a custom DPDK
> library path where it's been used meson for compile. It adds
> statically
> a linking rule "-ldpdk" that is wrong if you have used meson because
> libdpdk.so will not be available.
> In general, if you have a standard installation with DPDK library
> under
> /usr pkg-config do all works and yeah, I confirm that this is not
> needed.
> But if a user use custom path for compilation and meson for dpdk
> currently configuration doesn't work without force an external
> PKG_CONFIG_PATH variable as workaround.
> My cent.Regards
> On Tue, 2019-02-19 at 10:56 +0000, Luca Boccassi wrote:
> > On Tue, 2019-02-19 at 10:46 +0000, Ian Stokes wrote:
> > > On 2/19/2019 10:34 AM, Daniele Rondina wrote:
> > > > Hi, as describe on pr https://github.com/openvswitch/ovs/pull/2
> > > > 71
> > > >  i
> > > > prepared a minor fix for compile ovs with support to DPDK
> > > > library
> > > > compiled with meson.
> > > > 
> > > > Can anyone check if this doesn't introduce any regression and
> > > > if
> > > > could
> > > > be fine apply the same fix to 2.11 branch.
> > > > Thanks in advance
> > > > -- geaaru
> > > 
> > > Thanks Geaaru,
> > > 
> > > adding Christian, Luca and Timothy.
> > > 
> > > Guys any concerns WRT this on your side?
> > > 
> > > Ian
> > 
> > That change is not necessary - Christian's patches already added
> > support for pkg-config.
> > 
> > The user needs to let autoconf know the PKG_CONFIG_PATH at
> > configure
> > time if it's non-standard. Autotools already has ways to deal with
> > these things - custom changes should be avoided for sanity and
> > maintainability.
-- 
Kind regards,
Luca Boccassi