[ovs-dev] [PATCH v1 2/3] netdev-dpdk: Move offloading-code to a new file

Ophir Munk ophirmu at mellanox.com
Thu Feb 21 12:15:19 UTC 2019


Flavio, 
Following your review - v2 was sent, rebased on to of master. Empty lines were removed

> -----Original Message-----
> From: Flavio Leitner <fbl at sysclose.org>
> Sent: Wednesday, February 20, 2019 3:26 PM
> To: Ophir Munk <ophirmu at mellanox.com>
> Cc: ovs-dev at openvswitch.org; Shahaf Shuler <shahafs at mellanox.com>;
> Roni Bar Yanai <roniba at mellanox.com>; Ilya Maximets
> <i.maximets at samsung.com>
> Subject: Re: [ovs-dev] [PATCH v1 2/3] netdev-dpdk: Move offloading-code
> to a new file
> 
> On Mon, Feb 18, 2019 at 04:16:02PM +0000, Ophir Munk wrote:
> > From: Roni Bar Yanai <roniba at mellanox.com>
> >
> > Hardware offloading-code is moved to a new file called
> > netdev-rte-offloads.c. The original offloading-code is copied as is
> > from the netdev-dpdk.c file into the new file where future
> > offloading-code should be added as well. The netdev-dpdk.c file will
> > remain unchanged as new offloading-code is added.
> >
> > Reviewed-by: Asaf Penso <asafp at mellanox.com>
> > Signed-off-by: Roni Bar Yanai <roniba at mellanox.com>
> > Signed-off-by: Ophir Munk <ophirmu at mellanox.com>
...
> > +out:
> > +    free(patterns.items);
> > +    free(actions.actions);
> > +    return ret;
> > +}
> > +
> > +
> > +
> 
> Extra empty lines here. However, this patch doesn't apply anymore so I
> can't review it properly. Could you please rebase?
> 
> Thanks
> fbl
> 

Done in v2


More information about the dev mailing list