[ovs-dev] [PATCH v6 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-tests.

Asaf Penso asafp at mellanox.com
Thu Feb 21 14:23:58 UTC 2019


Ilya, I'm not yet familiar with the test syntax in .at file, but the rest of the series looks good.

Regards,
Asaf Penso

> -----Original Message-----
> From: Ilya Maximets <i.maximets at samsung.com>
> Sent: Wednesday, February 20, 2019 2:47 PM
> To: ovs-dev at openvswitch.org; Ian Stokes <ian.stokes at intel.com>
> Cc: Flavio Leitner <fbl at sysclose.org>; Ophir Munk
> <ophirmu at mellanox.com>; Kevin Traynor <ktraynor at redhat.com>; Roni Bar
> Yanai <roniba at mellanox.com>; Finn Christensen <fc at napatech.com>; Asaf
> Penso <asafp at mellanox.com>; Ilya Maximets <i.maximets at samsung.com>
> Subject: [PATCH v6 0/9] dpif-netdev: Partial HWOL fixes/refactoring/unit-
> tests.
> 
> Few more fixes + dummy implementation to enable unit testing
> of this feature.
> 
> 
> Version 6:
> 	* More specific log parsing in test.
> 	* Added Acks from Flavio to corresponding patches.
> 
> Version 5:
> 	* 'dp_packet_mbuf_init' --> generic 'dp_packet_init_special'
> 	* 'dp_packet_offload_invalidate' --> 'dp_packet_reset_offload'
> 	* Offload bitmasks turned to enum.
> 	* Dropped redundant OVS_UNUSED.
> 	* Added Acks from Flavio to corresponding patches.
> 
> Version 4:
> 	* Rebase on current master.
> 
> Version 3:
> 	* Skip tests on non-Linux systems.
> 
> Version 2:
> 	* Patch #3 rebased on top of current master.
> 
> 
> Ilya Maximets (9):
>   dpif-netdev: Reduce log level for not found mark id.
>   dp-packet: Constantify offloading APIs.
>   dp-packet: Refactor offloading API.
>   dp-packet: Add flow_mark support for non-DPDK case.
>   dp-packet: Copy flow mark on packet clone.
>   netdev-dummy: Implement dummy put/del flow offload API.
>   netdev-dummy: Set flow mark for offloaded flows.
>   netdev-dummy: Add flow offloading related logs.
>   dpif-netdev.at: Add basic test for partial HW offloading.
> 
>  lib/dp-packet.c      |  19 ++--
>  lib/dp-packet.h      | 106 +++++++++++-----------
>  lib/dpif-netdev.c    |   4 +-
>  lib/netdev-dpdk.c    |   6 +-
>  lib/netdev-dummy.c   | 206
> +++++++++++++++++++++++++++++++++++++++----
>  lib/netdev.c         |   4 +-
>  tests/dpif-netdev.at |  74 ++++++++++++++++
>  7 files changed, 337 insertions(+), 82 deletions(-)
> 
> --
> 2.17.1



More information about the dev mailing list