[ovs-dev] [PATCH branch-2.8/2.7] ovsdb-monitor.at: Use correct perl scripts.

[Zhou, Han]

On 2/26/19, 9:11 AM, "Zhou, Han" <hzhou8 at ebay.com> wrote:

    
    
    On 2/26/19, 4:39 AM, "Ilya Maximets" <i.maximets at samsung.com> wrote:
    
        Python scripts appeared only since OVS 2.9.
        This fixes unit test 'monitor-cond-change with many sessions pending'.
        Issue appered while backporting the following patch:
        e0f42d4a6548 ("monitor: Fix crash when monitor condition adds new columns.")
        
        Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
        ---
        
        Patch should go to branches 2.7 and 2.8.
        
         tests/ovsdb-monitor.at | 2 +-
         1 file changed, 1 insertion(+), 1 deletion(-)
        
        diff --git a/tests/ovsdb-monitor.at b/tests/ovsdb-monitor.at
        index 6d2baf324..f5280dd50 100644
        --- a/tests/ovsdb-monitor.at
        +++ b/tests/ovsdb-monitor.at
        @@ -630,7 +630,7 @@ AT_CHECK([ovsdb-client transact unix:socket '[["ordinals"]]'], [0],
                  [ignore], [ignore])
         AT_CHECK([ovs-appctl -t ovsdb-server -e exit], [0], [ignore], [ignore])
         OVS_WAIT_UNTIL([test ! -e ovsdb-server.pid && test ! -e ovsdb-client.pid])
        -AT_CHECK([$PYTHON $srcdir/ovsdb-monitor-sort.py < output | uuidfilt], [0], [[row,action,name
        +AT_CHECK([${PERL} $srcdir/ovsdb-monitor-sort.pl < output | ${PERL} $srcdir/uuidfilt.pl], [0], [[row,action,name
         <0>,insert,"""ten"""
         
         row,action,name
        -- 
        2.17.1
        
        
    Thanks for the fix. However, I don’t understand why only this test case causes the problem. Similar usages have been there for a long time in the same file, e.g. line 108:
       AT_CHECK([$PYTHON $srcdir/ovsdb-monitor-sort.py < output | uuidfilt], [0], [$7], [ignore])
    
    Should they be fixed, too?
    
    Thanks,
    Han
    
    
Sorry, please ignore my previous question. In 2.8 the line I mentioned was using PERL, too.

Thanks again for the fix.

Acked-by: Han Zhou <hzhou8 at ebay.com>