[ovs-dev] [PATCH] datapath-windows: Guard vport usage in user.c

aserdean at ovn.org aserdean at ovn.org
Thu Feb 28 10:09:12 UTC 2019


> Do we need to keep the dispatchLock for reading vport structures? 
[Alin Serdean] We need to make sure that port is not deleted since we use
it for processing.
>If that's
> the case, then we will need to fix it in other areas of the code too.
[Alin Serdean] I sent out https://patchwork.ozlabs.org/patch/1049043/ so we
can easily see where we need to change it. 
> It would
> be better to move the locking inside the relevant vport.c functions instead of
> taking out global ones.
[Alin Serdean] That would be ideal, but unfortunately if the vport is used
afterwards it needs to be guarded.
> 
> Thanks,
> Sairam
> 
> On 2/27/19, 6:10 AM, "ovs-dev-bounces at openvswitch.org on behalf of Alin
> Gabriel Serdean" <ovs-dev-bounces at openvswitch.org on behalf of
> aserdean at ovn.org> wrote:
> 
>     When using a vport we need to guard its usage with the dispatch lock.
> 
>     Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>
>     ---



More information about the dev mailing list