[ovs-dev] [PATCH v2 1/3] netdev: Dynamic per-port Flow API.

Ilya Maximets i.maximets at samsung.com
Mon Jul 1 10:46:28 UTC 2019


On 01.07.2019 13:24, Eli Britstein wrote:
> 
> On 7/1/2019 1:13 PM, Ilya Maximets wrote:
>> On 30.06.2019 7:47, Eli Britstein wrote:
>>> This patch breaks ovs-dpctl dump-flows, when using TC offloads (kernel).
>>>
>>> I added a print in netdev_flow_dump_create, and flow_api is NULL when
>>> invoking ovs-dpctl dump-flows.
>>>
>>> I think new netdev objects are created to the ports (netdev_open), but
>>> not properly initialized.
>>>
>>> Could you please have a look?
>>>
>> Hi. This is a known thing that ovs-dpctl is no longer suitable for dumping
>> of HW offloaded flows. Please, use 'ovs-appctl dpctl/dump-flows' instead.
>> There was a patch for documentation in v4 of patch-set:
>>      https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2019-May%2F359013.html&data=02%7C01%7Celibr%40mellanox.com%7Ceef52fe146404284578308d6fe0cc022%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636975728048962387&sdata=ktlkJhn7VpBfc0HXWFT0m4FACthk%2BwMAlsBFeYB3ZyA%3D&reserved=0
>> Here is the relevant thread:
>>      https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.openvswitch.org%2Fpipermail%2Fovs-dev%2F2019-May%2F358985.html&data=02%7C01%7Celibr%40mellanox.com%7Ceef52fe146404284578308d6fe0cc022%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636975728048962387&sdata=gfdSQ48i4CLjF6f1MVQCVyR%2FGcLqq72tmJ6ErAWLGig%3D&reserved=0
>>
>> However, I missed updating the NEWS about that change. Will send the patch
>> for this soon.
>>
>> Best regards, Ilya Maximets.
> 
> If that so, don't you think this should be either fixed or deprecated?

Fixing seems not possible, because ovs-dpctl is a standalone application
that works only with default configuration and HW offloading is disabled
by default.

Regarding deprecation, I'd like to remove all the functionality from ovs-dpctl
utility keeping only ability to remove system datapaths, since this, IMHO,
is the only useful function.

> Imagine some flows are in TC and some in OVS. I guess dpctl will only 
> show the OVS ones.

Yes, and this is documented.

> 
> I know about that appctl, but at least currently it misses some 
> information in the dump like "dp" and "offloaded".

appctl and dpctl works through the same code in lib/dpctl.c. So, everything
is supported. If you don't see those fields, increase the verbosity with
'--more' argument.

Best regards, Ilya Maximets.


More information about the dev mailing list