[ovs-dev] [PATCH 1/1] dpif-netlink: Warn eth type 0x1234 not offloadable

[Ben Pfaff]

On Sun, Jun 30, 2019 at 06:16:05AM +0000, Eli Britstein wrote:
> Ethernet type 0x1234 is used for testing and not being offloadable. For
> testing offloadable features, warn about using this value.
> 
> Signed-off-by: Eli Britstein <elibr at mellanox.com>
> ---
>  lib/dpif-netlink.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/dpif-netlink.c b/lib/dpif-netlink.c
> index ba80a0079..327076784 100644
> --- a/lib/dpif-netlink.c
> +++ b/lib/dpif-netlink.c
> @@ -2007,6 +2007,7 @@ parse_flow_put(struct dpif_netlink *dpif, struct dpif_flow_put *put)
>  
>      /* When we try to install a dummy flow from a probed feature. */
>      if (match.flow.dl_type == htons(0x1234)) {
> +        VLOG_WARN("eth 0x1234 is special and not offloadable");
>          return EOPNOTSUPP;
>      }

This should be rate-limited.

Are you sure that you want it to be a warning?  It does not seem to be
an actual problem, so INFO or even DBG might be better.