[ovs-dev] [PATCH] ossfuzz: Remove duplicate tcp flags parsing in flow extract target

Ben Pfaff blp at ovn.org
Wed Jul 3 18:09:58 UTC 2019


On Fri, Jun 21, 2019 at 02:50:35PM +0200, bshas3 at gmail.com wrote:
> From: Bhargava Shastry <bshas3 at gmail.com>
> 
> During a code audit, the flow extraction fuzzer target was seen to be
>  parsing tcp flags from the fuzzer supplied input twice. This is
> probably a typo since the second call to `parse_tcp_flags()` is
> identical to the first.
> Since a call to `parse_tcp_flags()` parses the Ethernet and IP headers
> contained in the packet, the second (buggy) call to `parse_tcp_flags()`
> creates an expectation that there is a second set of Ethernet and IP
> headers beyond the first which is incorrect. This patch fixes this
> problem by removing the duplicate code in question.
> 
> Signed-off-by: Bhargava Shastry <bshas3 at gmail.com>

Thanks.  Applied to master.


More information about the dev mailing list