[ovs-dev] [PATCH 3/4] OVN: Add ovn-northd IGMP support

[Dumitru Ceara]

On Thu, Jul 4, 2019 at 1:51 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Tue, Jul 02, 2019 at 09:07:58AM +0200, Dumitru Ceara wrote:
> > New IP Multicast Snooping Options are added to the Northbound DB
> > Logical_Switch:other_config column. These allow enabling IGMP snooping and
> > querier on the logical switch and get translated by ovn-northd to rows in
> > the IP_Multicast Southbound DB table.
> >
> > ovn-northd monitors for changes done by ovn-controllers in the Southbound DB
> > IGMP_Group table. Based on the entries in IGMP_Group ovn-northd creates
> > Multicast_Group entries in the Southbound DB, one per IGMP_Group address X,
> > containing the list of logical switch ports (aggregated from all controllers)
> > that have IGMP_Group entries for that datapath and address X. ovn-northd
> > also creates a logical flow that matches on IP multicast traffic destined
> > to address X and outputs it on the tunnel key of the corresponding
> > Multicast_Group entry.
> >
> > Signed-off-by: Dumitru Ceara <dceara at redhat.com>
>
> Seems reasonable at first glance, I'll do a more thorough review in a
> later version.
>
> I noticed a typo in the documentation: s/wether/whether/

I also spotted a different bug in the ovn_multicast_add_ports
function. I'll fix them in v2.

Thanks,
Dumitru