[ovs-dev] [PATCH v2] tnl-neigh-cache: Purge learnt neighbors when port/bridge is deleted

Ben Pfaff blp at ovn.org
Fri Jul 5 21:23:41 UTC 2019

On Thu, Jun 20, 2019 at 11:11:23AM -0400, Vasu Dasari wrote:
> Say an ARP entry is learnt on a OVS port and when such a port is deleted,
> learnt entry should be removed from the port. It would have be aged out after
> ARP ageout time. This code will clean up immediately.
> Added test case(tunnel - neighbor entry add and deletion) in tunnel.at, to
> verify neighbors are added and removed on deletion of a ports and bridges.
> Discussion for this addition is at:
> https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048754.html
> Signed-off-by: Vasu Dasari <vdasari at gmail.com>

The following use of nullable_string_is_equal in tnl_neigh_flush() seems
odd to me.  I don't see a caller to tnl_neigh_flush() that could pass
NULL, so the 'br_name' argument in nonnull.  neigh->br_name is an array,
not a pointer, so it is also always nonnull.  Why not use strcmp()?

Otherwise, this looks good, thank you.  I'll look forward to v3.

More information about the dev mailing list