[ovs-dev] [PATCH v3 2/5] dpif-netdev: Trigger parallel pmd reloads.

David Marchand david.marchand at redhat.com
Tue Jul 9 08:00:43 UTC 2019


On Tue, Jul 9, 2019 at 9:36 AM Ilya Maximets <i.maximets at samsung.com> wrote:

> On 09.07.2019 10:14, David Marchand wrote:
> > We can skip the non-PMD thread in this loop for consistency with
> dp_netdev_reload_pmd__() if this is what you meant.
> >
> > But for a non-PMD thread, pmd->reload is set to false at init and is
> never touched after this.
> > So in this case, this loop is supposed to break right away.
>
> Hmm. Yes, it seems that you're right. However, I think, it's better to
> not wait for non-PMD thread anyway for consistency and better readability.
>

I agree, skipping the non-PMD thread leaves no question on what to expect
of the code.
I will prepare a v4.

Is there anything else to rework in this series?

I will be on PTO on thursday evening for 10 days, so I'd like to address
any remaining comment by thursday morning.

-- 
David Marchand


More information about the dev mailing list