[ovs-dev] [PATCH v10 2/5] dpif-netdev: move dpcls lookup structures to .h
ian.stokes at intel.com
Wed Jul 10 15:51:40 UTC 2019
On 7/9/2019 1:34 PM, Harry van Haaren wrote:
> This commit moves some data-structures to be available
> in the dpif-netdev.h header. This allows specific implementations
> of the subtable lookup function to include just that header
> file, and not require that the code exists in dpif-netdev.c
> Signed-off-by: Harry van Haaren <harry.van.haaren at intel.com>
> Tested-by: Malvika Gupta <malvika.gupta at arm.com>
> - Rebase updates from previous patch in code that moved.
> - Move cmap.h include into alphabetical order (Ian)
> - Fix comment and typo (Ian)
> - Restructure function typedef to fit in 80 chars
Thanks for addressing the issues raised in v9,
Although previously I said this could be combined with patch 1 and 3,now
I'm thinking it might be better to leave them split as is. Logically
they accomplish separate goals in each patch.
Seeing the division of the patches in this series was definitely helpful
to myself during reviews so I'm thinking it may be helpful to others in
the future if they are moving from the current dpcls approach to this
generic approach. Unless there are objections I suggest we leave as is.
More information about the dev