[ovs-dev] [PATCH] checkpatch: Check FOR_EACH loops with numbers.

Ilya Maximets i.maximets at samsung.com
Fri Jul 12 15:33:32 UTC 2019

On 12.07.2019 18:20, Ben Pfaff wrote:
> On Fri, Jul 12, 2019 at 04:04:38PM +0300, Ilya Maximets wrote:
>> OVS has defines for loops like 'BITMAP_FOR_EACH_1' or
>> 'ULLONG_FOR_EACH_1', but the regexp in checkpatch doesn't match with
>> numbers and skips these loops while checking.
>> This patch adds numbers into regexp and adds some FOR_EACH loops to
>> the unit tests.
>> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks, Ben.

Can we consider this as a "bug fix" and apply or should we wait until
"freeze" finished?

For me either solution is OK.

Best regards, Ilya Maximets.

More information about the dev mailing list