[ovs-dev] [PATCH v1] ovs-macros: An option to suspend test execution on error

Ben Pfaff blp at ovn.org
Mon Jul 15 19:58:24 UTC 2019


On Mon, Jul 15, 2019 at 03:22:42PM -0400, Vasu Dasari wrote:
> Origins for this patch are captured at
> https://mail.openvswitch.org/pipermail/ovs-discuss/2019-June/048923.html.

...

Aaron provided helpful comments.  In addition:

> +ovs_pause() {
> +    $as_echo "====================================================="
> +    $as_echo "Set following environment variable to use various ovs utilities"
> +    $as_echo "export OVS_RUNDIR=$ovs_base"
> +    $as_echo "Press ENTER to continue: "
> +    read 
> +}

The above uses $as_echo, which is what the AS_ECHO([...]) macro expands
into.  It is better to use AS_ECHO itself, since in theory the
implementation could change in a later version of Autoconf.

Thanks,

Ben.


More information about the dev mailing list