[ovs-dev] [PATCH net-next] net: openvswitch: do not update max_headroom if new headroom is equal to old headroom

Taehee Yoo ap420073 at gmail.com
Tue Jul 16 12:28:30 UTC 2019

On Tue, 16 Jul 2019 at 03:15, Pravin Shelar <pshelar at ovn.org> wrote:

Hi Pravin,

> On Fri, Jul 5, 2019 at 9:08 AM Taehee Yoo <ap420073 at gmail.com> wrote:
> >
> > When a vport is deleted, the maximum headroom size would be changed.
> > If the vport which has the largest headroom is deleted,
> > the new max_headroom would be set.
> > But, if the new headroom size is equal to the old headroom size,
> > updating routine is unnecessary.
> >
> > Signed-off-by: Taehee Yoo <ap420073 at gmail.com>
> Sorry for late reply. This patch looks good to me too.
> I am curious about reason to avoid adjustment to headroom. why are you
> trying to avoid unnecessary changes to headroom.

Thank you for the review!
The intention of this patch is to remove unnecessary overhead.
There is no other reason.


> Thanks,
> Pravin.

More information about the dev mailing list