[ovs-dev] [PATCH] userspace: Enable non-bridge port as tunnel endpoint.

Ben Pfaff blp at ovn.org
Tue Jul 16 22:04:04 UTC 2019


On Tue, Jul 16, 2019 at 10:55:08AM -0700, Yifeng Sun wrote:
> For userspace datapath, currently only the bridge itself, the LOCAL port,
> can be the tunnel endpoint to encap/decap tunnel packets.  This patch
> enables non-bridge port as tunnel endpoint.  One use case is for users to
> create a bridge and a vtep port as tap, and configure underlay IP at vtep
> port as the tunnel endpoint.
> 
> Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
> Signed-off-by: William Tu <u9012063 at gmail.com>

Thanks for working on this!

I think that there might be a conceptual error in
is_neighbor_reply_correct() regarding IPv6.  This code adds an "if"
statement that tests for ARP, but nested inside it is code for matching
an IPv6 address.  This seems wrong.  Is it a mistake, or is there
something deeper going on here?

Thanks,

Ben.


More information about the dev mailing list