[ovs-dev] [PATCH] OVN resource agent - make promotion synchronous

Numan Siddique nusiddiq at redhat.com
Wed Jul 17 14:46:59 UTC 2019


On Wed, Jul 17, 2019 at 7:41 PM Aaron Conole <aconole at redhat.com> wrote:

> Michele Baldessari <michele at acksyn.org> writes:
>
> > On Wed, Jul 17, 2019 at 06:23:56AM -0500, Terry Wilson wrote:
> >> Is this just waiting on a couple of line length issues to be fixed? Or
> do
> >> those really matter?
> >
> > Hi Terry,
> >
> > I kind of ignored it because the ovn/utilities/ovndb-servers.ocf file
> > has already a bunch of lines > 79 chars. I can still fix it up if that
> > is preferred?
>
> Those shouldn't be 'blocking' anything.  It's to bring attention
> (warning vs. error).  Maybe it hasn't been looked at by Numan / aginwala
> yet.  CC'd for more attention.
>

I looked into this patch and acked it :).
I think we can ignore the warning for the shell files.

Thanks
Numan


>
> > cheers,
> > Michele
> >
> >>
> >> On Tue, Jul 9, 2019 at 3:10 AM 0-day Robot <robot at bytheb.org> wrote:
> >>
> >> > Bleep bloop.  Greetings Michele Baldessari, I am a robot and I have
> tried
> >> > out your patch.
> >> > Thanks for your contribution.
> >> >
> >> > I encountered some error that I wasn't expecting.  See the details
> below.
> >> >
> >> >
> >> > checkpatch:
> >> > WARNING: Line is 89 characters long (recommended limit is 79)
> >> > #50 FILE: ovn/utilities/ovndb-servers.ocf:545:
> >> >     ocf_log debug "ovndb_servers: Waiting for promotion $host_name as
> >> > master to complete"
> >> >
> >> > WARNING: Line is 82 characters long (recommended limit is 79)
> >> > #58 FILE: ovn/utilities/ovndb-servers.ocf:553:
> >> >     ocf_log debug "ovndb_servers: Promotion of $host_name as the
> master
> >> > completed"
> >> >
> >> > Lines checked: 64, Warnings: 2, Errors: 0
> >> >
> >> >
> >> > Please check this out.  If you feel there has been an error, please
> email
> >> > aconole at bytheb.org
> >> >
> >> > Thanks,
> >> > 0-day Robot
> >> > _______________________________________________
> >> > dev mailing list
> >> > dev at openvswitch.org
> >> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >> >
>


More information about the dev mailing list