[ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.

William Tu u9012063 at gmail.com
Wed Jul 17 15:47:54 UTC 2019


On Wed, Jul 17, 2019 at 8:41 AM Ilya Maximets <i.maximets at samsung.com> wrote:
>
> On 13.07.2019 2:50, William Tu wrote:
> > The patch introduces experimental AF_XDP support for OVS netdev.
> > AF_XDP, the Address Family of the eXpress Data Path, is a new Linux socket
> > type built upon the eBPF and XDP technology.  It is aims to have comparable
> > performance to DPDK but cooperate better with existing kernel's networking
> > stack.  An AF_XDP socket receives and sends packets from an eBPF/XDP program
> > attached to the netdev, by-passing a couple of Linux kernel's subsystems
> > As a result, AF_XDP socket shows much better performance than AF_PACKET
> > For more details about AF_XDP, please see linux kernel's
> > Documentation/networking/af_xdp.rst. Note that by default, this feature is
> > not compiled in.
> >
> > Signed-off-by: William Tu <u9012063 at gmail.com>
> > ---
>
> Hi Ben and William.
>
> This patch-set has a long history and the latest versions are in a good shape.
> netdev-afxdp works stable for me over the virtual interfaces and passes all the
> system tests that it needs to pass. Eelco is on a PTO now, but his last
> report [1] was that v14 of this patch worked fine for him in PVP tests. He had
> some issues with large packets, but this is, IMO, most probably due to kernel
> driver issues.
>
> So, I'd like to ask if we're going to merge netdev-afxdp to current release?
> For me it's totally fine, especially because netdev-afxdp implemented as a
> completely stand-alone feature that could be easily disabled. This way more
> users will be able to try and test this new feature with a 2.12 release.
>
> I made a review with a few style related comments and 2 small issues on a
> current version. If William will prepare the v17 today or tomorrow, I'll be
> able to re-check it and apply while we're in a soft-freeze stage.
>
> As an option, I could prepare v17 myself if William has no time for that.
>
>
> Ben, William, what do you think?
>
Hi Ilya,

Thanks a lot for your help on reviewing all these versions, and also
Eelco's review and testing. I will prepare v17 today.

Regards,
William

>
> CC Ian, as this is a big step for a userspace datapath.
>
> [1] https://mail.openvswitch.org/pipermail/ovs-dev/2019-July/360493.html
>
> Best regards, Ilya Maximets.


More information about the dev mailing list