[ovs-dev] [PATCHv16 2/2] netdev-afxdp: add new netdev type for AF_XDP.
i.maximets at samsung.com
Thu Jul 18 11:59:05 UTC 2019
On 17.07.2019 19:22, Ben Pfaff wrote:
> On Wed, Jul 17, 2019 at 06:41:48PM +0300, Ilya Maximets wrote:
>> This patch-set has a long history and the latest versions are in a good shape.
>> netdev-afxdp works stable for me over the virtual interfaces and passes all the
>> system tests that it needs to pass. Eelco is on a PTO now, but his last
>> report  was that v14 of this patch worked fine for him in PVP tests. He had
>> some issues with large packets, but this is, IMO, most probably due to kernel
>> driver issues.
>> So, I'd like to ask if we're going to merge netdev-afxdp to current release?
>> For me it's totally fine, especially because netdev-afxdp implemented as a
>> completely stand-alone feature that could be easily disabled. This way more
>> users will be able to try and test this new feature with a 2.12 release.
> I'm really glad to hear that! I was hoping that this would manage to
> make its way into 2.12. Because it is mostly new code, it is unlikely
> to cause nonobvious regressions, and so it's great to have it out there
> for people to try.
> I honestly haven't reviewed this myself because you've been doing such a
> great job. I've been looking at it for the last few minutes and I have
> a few minor comments that I'll send along soon. From what I see so far,
> my suggestions should be easy to incorporate and should not delay
> applying this.
Best regards, Ilya Maximets.
More information about the dev