[ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__

Ben Pfaff blp at ovn.org
Thu Jul 18 15:52:13 UTC 2019


On Wed, Jul 17, 2019 at 09:05:04PM +0200, Dumitru Ceara wrote:
> Once a column is set in a row using ovsdb_idl_txn_write__ we also mark
> the row "parsed". Otherwise the memory allocated by
> sbrec_<table>_parse_<col>() will never be freed. After marking the row
> "parsed", the ovsdb_idl_txn_disassemble function will properly free the
> newly allocated memory for the column (ovsdb_idl_row_unparse).

Wow, good catch.  I bet that's been there forever.

The OVSDB IDL code is too complicated.  It's too hard to spot the
issues.  I wish I saw a way to make it simpler.


More information about the dev mailing list