[ovs-dev] [PATCH] ovsdb-idl: Mark row "parsed" in ovsdb_idl_txn_write__
blp at ovn.org
Thu Jul 18 18:14:18 UTC 2019
On Thu, Jul 18, 2019 at 08:52:13AM -0700, Ben Pfaff wrote:
> On Wed, Jul 17, 2019 at 09:05:04PM +0200, Dumitru Ceara wrote:
> > Once a column is set in a row using ovsdb_idl_txn_write__ we also mark
> > the row "parsed". Otherwise the memory allocated by
> > sbrec_<table>_parse_<col>() will never be freed. After marking the row
> > "parsed", the ovsdb_idl_txn_disassemble function will properly free the
> > newly allocated memory for the column (ovsdb_idl_row_unparse).
> Wow, good catch. I bet that's been there forever.
> The OVSDB IDL code is too complicated. It's too hard to spot the
> issues. I wish I saw a way to make it simpler.
Oh, I forgot to say: I applied this to master.
More information about the dev